This repository has been archived by the owner on Apr 12, 2024. It is now read-only.
fix($compile) support templates with table content root nodes #5235
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR!
If you need to make changes to your pull request, you can update the commit with Thanks again for your help! |
ghost
assigned 
|
Edited to also support templateUrl templates |
|
Thanks for the fix. It work fine for me!! Hope it makes it into the next release |
This was referenced Dec 14, 2013
If the first element in a template is a <tr>, <th>, <td>, or <tbody> tag, the HTML compiler will ensure that the template is wrapped in a <table> element so that the table content is not discarded.
|
I think we should try to get mine, or one of the other solutions to this issue into the tree for the next release, since this would definitely be a pretty useful thing for people to have. I'm open to any feedback on the implementation and ways to improve it. |
|
lgtm |
|
+1 |
|
Merged in 31c450b |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some hack-ish logic to get compile to avoid throwing up on table content as root nodes.
I'm sure this can be improved upon, and certain things (like the regexp) could be moved outside of the function. Suggestions would be good.
demo1 | demo2
Closes #2848
Closes #1459
Closes #3647
Closes #3241